Skip to content

Move check for leaked shells to CloseTestWindowsRule #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HeikoKlare
Copy link
Contributor

The UITestCase contains a leaked shell check that would be better places in a test rule and fits to the already existing CloseTestWindowsRule.

This change integrates the leaked shell check into the CloseTestWindowsRule.

Copy link
Contributor

github-actions bot commented Aug 15, 2025

Test Results

 2 781 files  ±0   2 781 suites  ±0   1h 37m 33s ⏱️ - 18m 23s
 7 931 tests ±0   7 704 ✅ +2  227 💤 ±0  0 ❌  - 1 
23 336 runs  ±0  22 603 ✅ +2  733 💤 ±0  0 ❌  - 1 

Results for commit d7e6c30. ± Comparison against base commit b9d8b69.

♻️ This comment has been updated with latest results.

The UITestCase contains a leaked shell check that would be better places
in a test rule and fits to the already existing CloseTestWindowsRule.

This change integrates the leaked shell check into the
CloseTestWindowsRule.
@HeikoKlare HeikoKlare force-pushed the leakedshell-closetestwindowsrule branch from 2e78e5c to d7e6c30 Compare August 16, 2025 11:12
@HeikoKlare HeikoKlare changed the title Move leaked shell check to CloseTestWindowsRule Move check for leaked shells to CloseTestWindowsRule Aug 16, 2025
@HeikoKlare HeikoKlare merged commit e5929d3 into eclipse-platform:master Aug 18, 2025
18 checks passed
@HeikoKlare HeikoKlare deleted the leakedshell-closetestwindowsrule branch August 18, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant